Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Forms try to submit when logging in...

#105

While checking if I could add an extraa account, I noticed that when I fill out the form incorrectly, to raise an error, and then click on login and login. It asks if I want to resend my data on the reload, which I didn't do. It works properly at that point, but it does still try to create the account again.

Reported by Jason Brower · May 9th, 2009 @ 05:51 PM

State: resolved
Milestone: 0.5
Assigned to: Matias Korhonen Matias Korhonen

Activity

  1. Matias Korhonen
    Matias Korhonen
    • Milestone changed from 0.5 to 0.5.5 (Bug fix galore)

    This is a limitation of JavaScript. In order to reload the page with all the parts which are specific to logged in users the page has to be refreshed.

    I tried a couple of workarounds, but I couldn't get them to work.

    May 9th, 2009 @ 08:06 PM

  2. Matias Korhonen
    Matias Korhonen
    • Assigned user set to Joao Carlos

    May 10th, 2009 @ 10:26 PM

  3. Matias Korhonen
    Matias Korhonen

    Right. I just wasted another half hour trying to get this to work.

    And no, JS doesn't seem to be able to load the same page without submitting the form again.

    May 28th, 2009 @ 12:31 AM

  4. Joao Carlos
    Joao Carlos
    • Milestone changed from 0.5.5 (Bug fix galore) to 0.5

    I have a simple solution for this: getting rid of jQuery UI for the frontend. Besides, it has a lot of invalid CSS and adds 188 KiB of javascript.

    May 30th, 2009 @ 12:34 PM

  5. Joao Carlos
    Joao Carlos

    I will figure out a clean solution to redirect back to the previous page.

    May 30th, 2009 @ 12:35 PM

  6. Matias Korhonen
  7. Matias Korhonen
  8. Matias Korhonen
  9. Matias Korhonen
  10. Matias Korhonen
    Matias Korhonen

    (from [c2e84157ce0e892bd4207240e7d71c0d19e2a211]) Don't show the top login form if the controller is the users controller, a rough way of limiting the login forms to just one. [#105 Forms try to submit when logging in...]
    http://github.com/k33l0r/hhlc/commit/c2e84157ce0e892bd4207240e7d71c...

    June 15th, 2009 @ 01:16 AM

  11. Matias Korhonen
    Matias Korhonen
    • Assigned user changed from Joao Carlos to Matias Korhonen
    • State changed from open to testing

    June 15th, 2009 @ 01:16 AM

  12. Matias Korhonen
  13. Matias Korhonen
  14. Matias Korhonen
  15. Matias Korhonen
  16. Matias Korhonen
  17. Matias Korhonen
    Matias Korhonen

    Question: Should we use the solution we have on the current HEAD at this time (since about commit 11e90f9016ad31da775d453acc4caa721044fd5f ), or just use a separate login page, with redirection to the page from which the link was clicked?

    Personally, I'm starting to lean towards the login link (a much cleaner solution...)

    June 18th, 2009 @ 12:05 AM

  18. Matias Korhonen
    Matias Korhonen

    (from [9b8b481495f86eb72db4ac4b89e3d16a018eff5d]) A hacked up solution to redirect the user to the correct page after login/logout. This still needs work (I'm not sure if this is the
    correct/safe way of implementing this...) [#105 Forms try to submit when logging in...]
    http://github.com/k33l0r/hhlc/commit/9b8b481495f86eb72db4ac4b89e3d1...

    June 29th, 2009 @ 05:55 PM

  19. Matias Korhonen
    Matias Korhonen
    • State changed from testing to resolved

    Forms no longer submit when logging in., Any further issues should be handled in fresh tickets.

    June 30th, 2009 @ 02:10 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.